I agree with some of your thoughts here. Josh definitely profits from the pedal craze that he helps create but he also educates people about pedals and their lore, (mostly

giving credit to the creators of the circuits. His demos are always fitting. At the end of the day he sells pedals, telling people to focus on their playing and compositions would be counterproductive.
By the same rationale, I think players who demo pedals are just as guilty, if not more. For example, I respect the heck out of Andy Martin - the guy has been churning out riff after riff for over a decade - but every time he demos another pedal he creates a desire in people to own it. His latest demo is a Sabbadius fuzz that is "inspired by the Diaz Square Face" and "promises vintage fuzz tones and SRV glassy cleanup" and all it is is an NPN Si/Ge Fuzz Face on a repurposed board from 2020 with a "wah wah trick" knob that is nothing other than the Clean trimmer used in the Sunface (IIRC a Mike Fuller mod, originally). Read the comments and people say "I need this on my board/I know what I'm buying next". To be fair to Sabbadius, he explained all this on his FB page but should he have said "it's just another Fuzz Face"?
At the end f the day, Josh, Andy and Sabbadius are doing their job, it's people who are nuts. Look at some of us, buying the latest PCB when it's released "to try it out". FOMO consumerism is all-pervasive and we're all guilty.